Show when a task finished on a Done board card - #2077

@Birfy — review request for this pull request at c2698575fbdb0b5362b5e6489ec9c4ab1b6cbce3.

Checks are green at that exact tip (tests-ok, merge-gate, enqueue-guard, package, four plugins jobs); the team self-test for this tip is requested and will land in its own comment as advisory only — the verdict that counts is yours, on this head.

What the change is, in one line: a Done board card now shows when the task finished, drawn from the same card data the column already reads; P-360's rail key and the rail's counting stay as they are.

Self-test: PASS at c269857
as of my read: 1 comment, newest 6562062010

Team self-test on the named tip (read-only advisory; not the repository verdict and not a merge authorization).

Ran:

• API: PR head is this tip, tree 88a59e3e83e240e1fee5eae1e08cc5afbac84f61, one parent 8626664d, 8 files +191/−2, not a draft, mergeable clean; 14 check runs all success, tests-ok included.
• Tip tree: TZ=UTC node --import ./test/harness-resolve.mjs --test test/kanban.test.js → 20 tests / 20 pass / 0 fail.
• Red first: base 8626664d source + this tip's test file → 20 / 17 pass / 3 fail — the three the body names (first terminal entry, updatedAt fallback, room board), same counts.
• node scripts/ds-bot-patches.mjs check → 10 patches apply cleanly, core/ equals ds-bot/ + patches/ds-bot/; canonical → generate is a no-op; node core/scripts/build-client.mjs --check → exit 0, so the regenerated mirrors match a fresh generate/build.

Readings:

• core/src/client/kanban.js is additions only (+19, zero removed lines): one import, finishedAt, the finished const, one footer node, one CSS rule. P-360's bot:${scope.botId ?? ''} key and the [key] load effect are untouched, and the rail counting loop is still the base line (that belongs to #2076).
• finishedAt takes the first actors entry whose status is accepted, cancelled or failed, and only when its at is finite; otherwise a finite updatedAt; otherwise nothing. core/src/host/tasks.js:32-40 gives all three terminal statuses [], and rework opens a child card (reworkOf) instead of reopening, so the first terminal entry cannot be superseded later.
• The data is already on the wire: the host view has copied actors onto each card since before this change (tasks.js:349, unchanged in this diff), so no new field leaves the host and a card's existing viewers learn nothing new.
• The footer node is drawn only when column === 'done' and the stamp is finite and above zero, so neither Invalid Date nor 1970 is reachable; the other columns keep the footer they had (covered by test B). relativeShort is the existing helper — no new i18n keys.
• Security surface: client-side display only. No authz/permission logic, secrets, network calls, workflow or gate files, and no model-visible remote text; no display-name path touched.

Notes (not counted against this change):

• The updatedAt fallback still shows the edit time for a stored card whose terminal transition predates the actor history — documented in the changelog, and the alternative is no time at all.
• #2076 and this PR both touch kanban.js from the same base, so whichever lands first, the other needs a rebase. Ordering, as you said, not a defect.

Unverified by me:

• The full npm run verify (core and plugin suites) — I ran the kanban file locally; GitHub's tests-ok runs verify at this tip and is green.
• ARCH_DOCS_BASE=8626664d core/scripts/check-arch-docs.mjs — cannot diff here, the extracted tarball is not a git checkout; only one docs table row and a changelog entry changed.
• Nothing against a live instance.

Self-test: PASS at c269857
Written-by: FlyBot Test
as of my read: 2 comments, newest 6562071390

Team advisory self-test, independent of the earlier self-test comment 6562071390 at this tip; not a Verdict, not a review event, no merge authority — the repository reviewer's verdict stays the authority.

Ran:

• Rebuilt both trees from codeload tarballs and checked them byte for byte: base 8626664d → tree 101ffafa, tip c2698575 → tree 88a59e3e (git write-tree == the API tree), one commit, one parent, 8 files +191/−2, not a draft, maintainer_can_modify true, mergeable clean.
• Red first, base source + this tip's core/test/kanban.test.js, three runs: 20 tests / 17 pass / 3 fail, identical each run.
• Tip, same file, three runs: 20 / 20 / 0.
• Host side read at the tree: core/src/host/tasks.js record() (updatedAt stamped on every transition, actors push at :269), TRANSITIONS terminals (accepted/cancelled/failed have no exit, :30-39), the plain-edit path (by: 'updated', :1456), view() passing actors through (:349), and no truncation of actors anywhere in the file — so the first terminal entry really is the finish and stays in the record.
• Seven mutation arms on the tip (each alone, one line in core/src/client/kanban.js, full file run).
• TZ=UTC ARCH_DOCS_BASE=<local base commit, tree == 8626664d> npm run verify twice: exit 0 both, identical.
• node scripts/ds-bot-patches.mjs generate twice (git status empty → no-op), check, canonical, node core/scripts/build-client.mjs --check (0), node .github/scripts/changelog.mjs check (49 fragments), node .github/scripts/check-mojibake.mjs --check (0 occurrences / 1404 files), checkpointReasons(body, …) → [].

Red first on 8626664d, the three the body names, with the assertion diff:

• a Done card says when it finished, from the first terminal actor entry — undefined !== '2 h'
• a Done card with no actor entry falls back to updatedAt — undefined !== '3 h'
• a room board Done card says when it finished too — undefined !== '2 h'

Mutation arms (red out of 20):

• last terminal entry instead of the first → 2 red: the first-terminal case and the room case ('1 min' !== '2 h'). Matches the body.
• updatedAt instead of the terminal entry → 2 red: the same two.
• drop column === 'done' → 1 red: an In progress card carries no finish time.
• drop the finished > 0 guard → 1 red: a Done card without a usable timestamp draws no time and no Invalid Date (the zero stamp draws 1970).
• drop the finite guard (finished > 0 || finished === 0) → 1 red: the same case (Invalid Date).
• remove the updatedAt fallback → 1 red: a Done card with no actor entry falls back to updatedAt.
• drop cancelled/failed from TERMINAL_STATUSES → 0 red (see below).

Scope:

• core/src/client/kanban.js is pure additions (zero deletions): the import, TERMINAL_STATUSES/finishedAt, one finished computation, one footer node, one CSS rule and its comment. P-360's key is byte-identical (base :172, this tip :186); #2069's rail sum line is untouched and still in its base form (base :403, this tip :421) — this branch is based on 8626664d and does not carry #2076, so whichever merges second needs a rebase. That is ordering, not a regression.
• core/test/kanban.test.js only appends (66 lines, 0 deletions; no existing assertion touched). core/client.js and patches/ds-bot/ regenerate cleanly (gates above), so nothing was hand-written into the bundle.
• The fragment (changelog.d/2066-board-done-time.added.md, .added — a user-visible addition, matches the change) and the docs/subsystems/core-client.md sentence both read true against the diff: first terminal entry, updatedAt only as fallback, no node when neither is usable, other columns unchanged, relativeShort's existing strings (just now, {n} min, {n} h, {n} d, Sep 22). No new i18n key, no absolute sentence.

One gap, not a regression:

• Dropping cancelled and failed from TERMINAL_STATUSES keeps all 20 tests green: every case uses accepted, although cancelled and failed are both Done-column statuses (core/src/shared/task-board.js:16-17) and the doc row and the fragment both name all three. The code is right; a later case with a cancelled or failed card would pin it.
• Untested edge, harmless with the host as it is: finishedAt takes the first terminal entry even when its at is not a finite number, then falls back to updatedAt instead of looking at a later terminal entry — record() always stamps a number, so this cannot happen from the host today.

verify (both runs identical): core 2553/2553, plugins/social 541, plugins/tree 127, plugins/timeline 135, plugins/workflow 336, .github/scripts 563, interop 37, live-e2e 24; core lint 73 warnings / 0 errors, plugin lints 36 / 9 / 2 / 16, 0 errors; arch-docs: OK (8 changed file(s)).

Nothing in the body disagreed with my readings.

Not verified by me:

• Real browser DOM, screenshots, the actual rendering of .bt-board-when and its colour in a theme: this file's harness draws the client bundle in a fake React runtime.
• smoke/bench, the packaged Desktop build, Windows, and the CI package job (pack check, typecheck, actionlint) — npm run verify does not run them.
• Nothing against a live instance.

Verdict: PASS at c269857
Written-by: Reviewer
Attestation: c269857 role=Reviewer

Ran at this tip:

$ TZ=UTC node --import ./test/harness-resolve.mjs --test test/kanban.test.js
# tests 20  # pass 20  # fail 0
$ cp /base/core/src/client/kanban.js src/client/kanban.js && TZ=UTC node --import ./test/harness-resolve.mjs --test test/kanban.test.js
# tests 20  # pass 17  # fail 3
$ node scripts/build-client.mjs && cmp <tip>/core/client.js core/client.js
# bundle up to date

Red-first (hard requirement) — base 8626664d source with this tip's core/test/kanban.test.js, three failures, exactly the three the body names:

• a Done card says when it finished, from the first terminal actor entry → undefined !== '2 h'
• a Done card with no actor entry falls back to updatedAt → undefined !== '3 h'
• a room board Done card says when it finished too → undefined !== '2 h'

What I checked:

• Tree matches the PR: codeload tarball at c2698575 vs base 8626664d → exactly the 8 files, +191/−2, tree 88a59e3e; patches/ds-bot/files/src/client/kanban.js and .../test/kanban.test.js are byte-identical to the core copies, and the regenerated core/client.js compares equal to the committed bundle (not stale).
• Logic: finishedAt reads the first terminal entry in task.actors — record() (src/host/tasks.js:274) appends chronologically and updatedAt is bumped on plain edits too (:269), so first-terminal is the transition that ended the task and later same-status entries are edits. Falls back to finite updatedAt, and the footer's Number.isFinite(finished) && finished > 0 guard means no node at all for a missing/zero stamp (no Invalid Date, no 1970). Non-Done columns are untouched.
• Scope: only core/src/client/kanban.js behaviour (~19 lines) plus the test, the two regenerated artifacts, the docs row and the changelog fragment. No host/API change, so the smoke test genuinely wasn't needed.
• Checks at this tip (API commit/check-runs, 14/14 completed success): tests-ok, merge-gate, enqueue-guard, package, agent-audience, judge, risk tier (report only), reviewed tip (report only), four plugins jobs — no failure. mergeable: true, mergeable_state: clean, base is current main 8626664d.

Label agent-pr was missing on the PR; added.

@Birfy — review request for this pull request at c926c75339fb56c41011cbc0e1aa3e0d710aa776.

This head is the same change rebased onto the current main 8540c35c95e1a1125ad00c2ebc46655bd730a64a (single parent): core/src/client/kanban.js +19, test +66, the two regenerated artifacts, one docs row, one changelog fragment; conflicts were in the test file, the docs row and the test mirror, resolved by keeping main's #2069 lines plus this change's five tests.

Checks at this exact tip are green (14/14, tests-ok and enqueue-guard included); mergeable: true, maintainer_can_modify: true.

What the change is, in one line: a Done board card now shows when the task finished, taken from the first terminal entry in the card's actors, falling back to updatedAt, drawn only when the stamp is usable; P-360's rail key and the rail's counting stay as they are.

The earlier verdict at c2698575… does not carry over to this tip; the team self-test will land in its own comment as advisory only.

Self-test: PASS at c926c75
Written-by: FlyBot Security
as of my read: 5 comments, newest 6565960830

Advisory only — not a review, no Verdict:; the repository reviewer's verdict is the authority. This covers the rebased tip only; my advisory 6562071390 stays at c2698575….

Tip c926c753…: single parent 8540c35c95e1 (the live main ref), 8 files +191/−2.

Ran:

• node --test core/test/kanban.test.js at the tip: 21/21.
• the same test file against 8540c35c sources: 16/21, red A (first terminal entry draws 2 h), C (updatedAt fallback draws 3 h), E (room board Done card) — B and D pass there already because the old code drew no node at all.
• base's own file at base: 16/16, so the three reds are the five new tests, not drift.
• board-card.test.js 2/2, ui-clickthrough.test.js 12/12.
• node core/scripts/build-client.mjs --check exit 0.
• node scripts/ds-bot-patches.mjs check → 10 patches apply cleanly in order, core/ equals ds-bot/ + patches/ds-bot/; canonical → generate is a no-op; node .github/scripts/changelog.mjs check ok.
• cmp patches/ds-bot/files/src/client/kanban.js core/src/client/kanban.js and the test mirror: identical.

Rebase resolution, checked against base text rather than the PR's own wording:

• The rail line is main's: [...(scope?.kind === 'group' ? groupTasks : own), ...(archive ?? []).slice(0, ARCHIVE_SHOWN)], byte-identical to 8540c35c's line, and P-360's bot:${scope.botId ?? ''} key is base text too. Old tip → new tip changes kanban.js only in that A room board reached from a Bot board counts its active cards twice in the rail #2069 line and its comment; the Board cards in the Done column never show when the task finished #2066 hunks are unchanged.
• core/test/kanban.test.js is base's file with A room board reached from a Bot board counts its active cards twice in the rail #2069's harness change and test intact, plus the five Board cards in the Done column never show when the task finished #2066 tests appended verbatim (the old-tip → new-tip diff adds only A room board reached from a Bot board counts its active cards twice in the rail #2069 material); docs/subsystems/core-client.md keeps base's A room board reached from a Bot board counts its active cards twice in the rail #2069 sentence and appends the Board cards in the Done column never show when the task finished #2066 one.
• core/client.js and both patches/ds-bot/ mirrors carry the same Board cards in the Done column never show when the task finished #2066 hunks; they are regenerated (gates above), not hand-edited, and 0008-client-bundle.patch's hunk header moved +6774 → +6783, i.e. the nine added bundle lines.

Substance is what I checked at c2698575…, unchanged: finishedAt takes the first terminal entry in actors (accepted / cancelled / failed; TRANSITIONS has no way out of all three, core/src/host/tasks.js:29-36) and falls back to a finite updatedAt, else draws nothing; the node is drawn only for column === 'done' with a finite value above zero, so Invalid Date and 1970 cannot render; the footer and CSS additions are otherwise the only change. Host view() still ships actors and the archive page goes through it, so Done rows on a Bot board and a room board carry the history the stamp reads.

Not verified: full npm run verify locally (tests-ok covers it at this tip; 14/14 checks green on this sha), and no live instance render.

Self-test: PASS at c926c75
Written-by: FlyBot Test
as of my read: 6 comments, newest 6565991151

Advisory only — not a review, no Verdict:; the repository reviewer's verdict is the authority. Covers this rebased tip only; my earlier advisory 6562116541 stays at c2698575….

Ran (all at c926c753…, tree dac5ebe7…, single parent 8540c35c95e1 = live main):

• red first: base 8540c35c sources + this PR's core/test/kanban.test.js, TZ=UTC node --import ./test/harness-resolve.mjs --test test/kanban.test.js ×3 → 21 tests / 18 pass / 3 fail each run, the three failing exactly #17 a Done card says when it finished, from the first terminal actor entry (undefined !== '2 h'), #19 a Done card with no actor entry falls back to updatedAt (undefined !== '3 h'), #21 a room board Done card says when it finished too (undefined !== '2 h').
• same command at the tip ×3 → 21 / 21 / 0 each run.
• TZ=UTC ARCH_DOCS_BASE=<local base commit> npm run verify ×2 → exit 0 both, identical: core 2554/2554, social 541, tree 127, timeline 135, workflow 336, .github/scripts 572, interop 37, live-e2e 24; core lint 73 warnings / 0 errors, plugins 36 / 9 / 2 / 16 warnings, 0 errors; arch-docs: OK (8 changed file(s)); changelog: 2 fragment(s); mojibake: ok — 0 occurrences of U+FFFD in 1357 text file(s); checkpointReasons(body,{pr:2077,files}) → [].
• bundle/mirrors: node core/scripts/build-client.mjs --check exit 0; node scripts/ds-bot-patches.mjs check → ok 10 patches apply cleanly in order, ok core/ equals ds-bot/ + patches/ds-bot/; then a real build-client + ds-bot-patches generate → both checks still exit 0 and git status shows no change to any tracked file (only the two node_modules symlinks I add to run tests, never committed). So core/client.js and both patches/ds-bot/ mirrors are the tree's own output, not hand-edited.

Rebase resolution, read against base text:

• rail sum line: base :404, tip :422, byte-identical for (const task of [...(scope?.kind === 'group' ? groupTasks : own), ...(archive ?? []).slice(0, ARCHIVE_SHOWN)]); P-360 key: base :172, tip :186, identical scope?.kind === 'group' ? \group:…` : `bot:${scope.botId ?? ''}`. kanban.js's +19 lines are the five Board cards in the Done column never show when the task finished #2066` places only.
• core/test/kanban.test.js vs base is a pure append (+66, no deletions): main's 16 tests untouched, the five new ones appended; red-first above is therefore the new tests, not drift.
• docs/subsystems/core-client.md replaces one table row (adds the #2066 sentence, keeps #2069/P-364/P-360 text); changelog.d/2066-board-done-time.added.md is an .added.md fragment and matches the change.

Mutation arms on this tip, each applied alone to the source and reverted (21 tests):

• take the last terminal entry instead of the first → 19/2, red #17, #21
• use updatedAt instead of the terminal entry → 19/2, red #17, #21
• drop the column === 'done' guard → 20/1, red #18 (an In progress card draws bt-board-when)
• drop the finite/> 0 footer guard → 19/2, red #18, #20 (Invalid Date / 1970 can render)
• revert the footer line alone to base → 18/3, red #17, #19, #21
• remove cancelled/failed from the terminal set → 21/21, still green — same coverage gap I reported at c2698575…; both are Done-column statuses (core/src/shared/task-board.js), only accepted is pinned by a test. Not a defect in this change, but not nailed down either.

Body claims checked at base 8540c35c: core/src/host/tasks.js:267-270 (every transition stamps updatedAt), :1456 (plain edit re-records by: 'updated'), :30-39 (accepted/cancelled/failed have no way out), core/src/client/text.js:64-71 (relativeShort: just now, {n} min, {n} h, {n} d, then a date) — all as written.

Inconsistent with the body:

• the checkpoint JSON says checks.at: c926c75339fb56c41011cbc0e1aa3e0d710aa776, while the prose two paragraphs above says "checks.at names the commit the checks actually ran at" and gives it as dfb9faedeeaffb4ba698babb8c7c4513699d6cba. One of the two is stale; dfb9faed… is not on GitHub (422), so it is the push-time local commit.
• the body's mutation "drop the column === 'done' / finite guard → 21/19/2 (B and D red)" bundles two guards: split apart, the column guard alone turns #18 red (20/1) and the finite footer guard turns #18 and #20 red (19/2). Same coverage, finer reading.

Not verified: real browser DOM/screenshot and clipboard; smoke and bench (nothing under core/index.js or core/src/host/ changed); packaged Desktop; Windows; the CI package job (pack / typecheck / actionlint); enqueue-guard (tests-ok covers it on this sha, not re-runnable locally).

Note: another advisory sits at this same tip (6565991151, FlyBot Security); it stays as it is. Its "16/21" for the base-source run reads as 18/21 by my measurement — same three reds, counting difference only.